run/qemu: remove usb and device flags

refactor: move qemu to its own package
tests: implements end to end tests for the convert command with the following images: alpine:3.17, ubuntu:20.04, debian:11, centos:8

Signed-off-by: Adphi <philippe.adrien.nousse@gmail.com>

pkg/docker/check_term_unix.go

@@ -0,0 +1,28 @@
+//go:build !windows
+
+// Copyright 2023 Linka Cloud  All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package docker
+
+import (
+	"os"
+
+	"golang.org/x/sys/unix"
+)
+
+func isInteractive() bool {
+	_, err := unix.IoctlGetWinsize(int(os.Stdout.Fd()), unix.TIOCGWINSZ)
+	return err == nil
+}

pkg/docker/check_term_windows.go

@@ -0,0 +1,36 @@
+//go:build windows
+
+// Copyright 2023 Linka Cloud  All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package docker
+
+import (
+	"os"
+
+	"golang.org/x/sys/windows"
+)
+
+func isInteractive() bool {
+	handle := windows.Handle(os.Stdout.Fd())
+	var mode uint32
+	if err := windows.GetConsoleMode(handle, &mode); err != nil {
+		return false
+	}
+	mode |= windows.ENABLE_VIRTUAL_TERMINAL_PROCESSING
+	if err := windows.SetConsoleMode(handle, mode); err != nil {
+		return false
+	}
+	return true
+}

pkg/docker/docker.go

@@ -130,7 +130,14 @@ func RunD2VM(ctx context.Context, image, version, in, out, cmd string, args ...s
 	if version == "" {
 		version = "latest"
 	}
-	a := []string{
+	a := []string{"run", "--rm"}
+
+	interactive := isInteractive()
+
+	if interactive {
+		a = append(a, "-i", "-t")
+	}
+	a = append(a,
 		"--privileged",
 		"-e",
 		// yes... it is kind of a dirty hack
@@ -145,6 +152,12 @@ func RunD2VM(ctx context.Context, image, version, in, out, cmd string, args ...s
 		"/d2vm",
 		fmt.Sprintf("%s:%s", image, version),
 		cmd,
+	)
+	c := exec.CommandContext(ctx, "docker", append(a, args...)...)
+	if interactive {
+		c.Stdin = os.Stdin
 	}
-	return RunInteractiveAndRemove(ctx, append(a, args...)...)
+	c.Stdout = os.Stdout
+	c.Stderr = os.Stderr
+	return c.Run()
 }