From f9d4a067ecb9d3fa65326e5e6a76649ccf65434c Mon Sep 17 00:00:00 2001 From: Cory Snider Date: Sun, 15 Apr 2018 08:45:58 -0400 Subject: [PATCH] Reduce number of git calls when displaying prompt (#3795) The avit theme's _git_time_since_commit function was running git twice. Reduce it with a single call to `git log`, checking the exit code for success. --- themes/avit.zsh-theme | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/themes/avit.zsh-theme b/themes/avit.zsh-theme index 4f0dcbcc..c43fcc9f 100644 --- a/themes/avit.zsh-theme +++ b/themes/avit.zsh-theme @@ -50,9 +50,7 @@ function _ruby_version() { # use a neutral color, otherwise colors will vary according to time. function _git_time_since_commit() { # Only proceed if there is actually a commit. - if git log -1 > /dev/null 2>&1; then - # Get the last commit. - last_commit=$(git log --pretty=format:'%at' -1 2> /dev/null) + if last_commit=$(git log --pretty=format:'%at' -1 2> /dev/null); then now=$(date +%s) seconds_since_last_commit=$((now-last_commit))