adphi/oh-my-zsh
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Inline parse_svn to avoid leaky state

Browse Source 
As noted in review, `in_svn` is not properly reset to false. This is better anyway to not leak state.
This commit is contained in:
Brice Dutheil 2014-01-07 02:10:34 +01:00
parent 1304ed8d25
commit 642ae64bc5
1 changed files with 17 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/svn-fast-info/svn-fast-info.plugin.zsh
View File

@ -9,7 +9,7 @@
# #
# *** IMPORTANT *** DO NO USE with the simple svn plugin, this plugin acts as a replacement of it. # *** IMPORTANT *** DO NO USE with the simple svn plugin, this plugin acts as a replacement of it.
function parse_svn() { function svn_prompt_info() {
info=$(svn info 2>&1) || return; # capture stdout and stdout info=$(svn info 2>&1) || return; # capture stdout and stdout
in_svn=true in_svn=true
repo_need_upgrade="$(svn_repo_need_upgrade $info)" repo_need_upgrade="$(svn_repo_need_upgrade $info)"
@ -17,10 +17,6 @@ function parse_svn() {
svn_dirty="$(svn_dirty_choose)" svn_dirty="$(svn_dirty_choose)"
svn_repo_name="$(svn_get_repo_name $info)" svn_repo_name="$(svn_get_repo_name $info)"
svn_rev="$(svn_get_revision $info)" svn_rev="$(svn_get_revision $info)"
}
function svn_prompt_info() {
eval parse_svn
if [ ! -z $repo_need_upgrade ]; then if [ ! -z $repo_need_upgrade ]; then
echo $ZSH_PROMPT_BASE_COLOR$ZSH_THEME_SVN_PROMPT_PREFIX$ZSH_PROMPT_BASE_COLOR\ echo $ZSH_PROMPT_BASE_COLOR$ZSH_THEME_SVN_PROMPT_PREFIX$ZSH_PROMPT_BASE_COLOR\