From 5de6253b0c83a12fb3a7c145f711a1ea9ca9207e Mon Sep 17 00:00:00 2001 From: Scott Rice Date: Thu, 24 Sep 2015 09:58:04 -0700 Subject: [PATCH] [hg] Cache the result of the `in_hg` call within `hg_prompt_info` helpers The helper functions are smart only work if the user is in an hg repository. Unfortunately checking that fact can take a while for large repos, so these redundant checks are taking a while. This diff stores the result of the first call from `hg_prompt_info` in a local variable and just checks that for every other function. This gave me a multi-second speedup locally. --- plugins/mercurial/mercurial.plugin.zsh | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/plugins/mercurial/mercurial.plugin.zsh b/plugins/mercurial/mercurial.plugin.zsh index 87dca5e5..bb95fd33 100644 --- a/plugins/mercurial/mercurial.plugin.zsh +++ b/plugins/mercurial/mercurial.plugin.zsh @@ -26,22 +26,24 @@ function in_hg() { } function hg_get_branch_name() { - if [ $(in_hg) ]; then + if [ $_INHG ]; then echo $(hg branch) fi } function hg_prompt_info { - if [ $(in_hg) ]; then + _INHG=$(in_hg) + if [ $_INHG ]; then _DISPLAY=$(hg_get_branch_name) echo "$ZSH_PROMPT_BASE_COLOR$ZSH_THEME_HG_PROMPT_PREFIX\ $ZSH_THEME_REPO_NAME_COLOR$_DISPLAY$ZSH_PROMPT_BASE_COLOR$ZSH_PROMPT_BASE_COLOR$(hg_dirty)$ZSH_THEME_HG_PROMPT_SUFFIX$ZSH_PROMPT_BASE_COLOR" unset _DISPLAY fi + unset _INHG } function hg_dirty_choose { - if [ $(in_hg) ]; then + if [ $_INHG ]; then # Allow turning off the 'hg status' call. Useful in large repos where that # can take a while. Mirror the functionality of the git plugin by just # showing the "clean" prompt in this case.