adphi/occweb
1
0
Fork 2
Code Issues Pull Requests 1 Releases 4 Wiki Activity

Fix issues for Nextcloud 17 compatibility #7

New Issue
Closed
opened 2019-11-16 13:07:03 +00:00 by Ghost · 4 comments
Ghost commented 2019-11-16 13:07:03 +00:00
Copy Link

Hi,

I have been testing OCCWeb in NC 17, and everything seems to work fine.

Nevertheless, to be fully compliant there are some smaller issues that need to be fixed, it seems.

occ $ app:check-code occweb
Analysing /var/www/html/custom_apps/occweb/lib/Controller/OCCApplication.php
 8 errors
    line   34: OC_App - private class must not be imported with a use statement
    line   68: OC_Util - Static method of private class must not be called
    line  119: OC_App - Static method of private class must not be called
    line  121: OC_App - Static method of private class must not be called
    line  126: OC_App - Static method of private class must not be called
    line  126: OC_App::getAppInfo - Method of deprecated class must not be called
    line  131: OC_App - Static method of private class must not be called
    line  153: OC_Util - Static method of private class must not be called
App is not compliant

Thank you for this great admin tool! 👍

Hi, I have been testing OCCWeb in NC 17, and everything seems to work fine. Nevertheless, to be fully compliant there are some smaller issues that need to be fixed, it seems. ``` occ $ app:check-code occweb Analysing /var/www/html/custom_apps/occweb/lib/Controller/OCCApplication.php 8 errors line 34: OC_App - private class must not be imported with a use statement line 68: OC_Util - Static method of private class must not be called line 119: OC_App - Static method of private class must not be called line 121: OC_App - Static method of private class must not be called line 126: OC_App - Static method of private class must not be called line 126: OC_App::getAppInfo - Method of deprecated class must not be called line 131: OC_App - Static method of private class must not be called line 153: OC_Util - Static method of private class must not be called App is not compliant ``` Thank you for this great admin tool! 👍
adphi commented 2019-11-16 13:10:21 +00:00
Owner
Copy Link

Thank for reporting this issue.
I don't have much time at the moment to take a deep look into that. But I will as soon as I can.

Thank for reporting this issue. I don't have much time at the moment to take a deep look into that. But I will as soon as I can.
rakekniven commented 2020-01-24 14:58:19 +00:00
Copy Link

Hello,

Nextcloud 18 is out and we have users at the help forums asking for your fantastic app.

Any chance you can spend some attention to this app?

Hello, Nextcloud 18 is out and we have users at the help forums asking for your fantastic app. Any chance you can spend some attention to this app?
adphi commented 2020-01-26 15:04:17 +00:00
Owner
Copy Link

This should be fixed.

$ php occ app:check-code occweb
App is compliant - awesome job!
This should be fixed. ``` $ php occ app:check-code occweb App is compliant - awesome job! ```
adphi closed this issue 2020-01-26 15:04:17 +00:00
rakekniven commented 2020-01-26 16:05:16 +00:00
Copy Link

Well done! Thank you

Well done! Thank you
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: adphi/occweb#7
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?