8e8f33ef46
When Nextcloud performs an upgrade or clean installation,
it will check whether /var/www/html/{config,data,custom_apps,themes} exist.
If not, it will copy
/usr/src/nextcloud/{config,data,custom_apps,themes} to /var/www/html.
This leads to a problem: If those subdirectories are existent but
empty, it will not do the copy. This situation is common when you mount
volumes to those subdirectories, like:
```
version: "2.1"
services:
app:
image: nextcloud:12-apache
volumes:
- nextcloud:/var/www/html:Z
- nextcloud-custom_apps:/var/www/html/custom_apps:Z
- nextcloud-config:/var/www/html/config:Z
- nextcloud-data:/var/www/html/data:Z
- nextcloud-themes:/var/www/html/themes:Z
ports:
- 8080:80/tcp
db:
image: mariadb
volumes:
- db:/var/lib/mysql:Z
environment:
MYSQL_USER: nextcloud
MYSQL_DATABASE: nextcloud
MYSQL_PASSWORD: nextcloud
MYSQL_ROOT_PASSWORD: nextcloud
volumes:
nextcloud:
nextcloud-custom_apps:
nextcloud-config:
nextcloud-data:
nextcloud-themes:
db:
```
This patch will fix this issue by copying to those subdirectories when they
are empty.
49 lines
1.9 KiB
Bash
Executable File
49 lines
1.9 KiB
Bash
Executable File
#!/bin/bash
|
|
set -e
|
|
|
|
# version_greater A B returns whether A > B
|
|
function version_greater() {
|
|
[[ "$(printf '%s\n' "$@" | sort -V | head -n 1)" != "$1" ]];
|
|
}
|
|
|
|
# return true if specified directory is empty
|
|
function directory_empty() {
|
|
[ -n "$(find "$1"/ -prune -empty)" ]
|
|
}
|
|
|
|
|
|
installed_version="0.0.0~unknown"
|
|
if [ -f /var/www/html/version.php ]; then
|
|
installed_version=$(php -r 'require "/var/www/html/version.php"; echo "$OC_VersionString";')
|
|
fi
|
|
image_version=$(php -r 'require "/usr/src/nextcloud/version.php"; echo "$OC_VersionString";')
|
|
|
|
if version_greater "$installed_version" "$image_version"; then
|
|
echo "Can't start Nextcloud because the version of the data ($installed_version) is higher than the docker image version ($image_version) and downgrading is not supported. Are you sure you have pulled the newest image version?"
|
|
exit 1
|
|
fi
|
|
|
|
if version_greater "$image_version" "$installed_version"; then
|
|
if [ "$installed_version" != "0.0.0~unknown" ]; then
|
|
su - www-data -s /bin/bash -c 'php /var/www/html/occ app:list' > /tmp/list_before
|
|
fi
|
|
rsync -a --delete --exclude /config/ --exclude /data/ --exclude /custom_apps/ --exclude /themes/ /usr/src/nextcloud/ /var/www/html/
|
|
|
|
for dir in config data custom_apps themes; do
|
|
if [ ! -d /var/www/html/"$dir" ] || directory_empty /var/www/html/"$dir"; then
|
|
cp -arT /usr/src/nextcloud/"$dir" /var/www/html/"$dir"
|
|
fi
|
|
done
|
|
|
|
if [ "$installed_version" != "0.0.0~unknown" ]; then
|
|
su - www-data -s /bin/bash -c 'php /var/www/html/occ upgrade --no-app-disable'
|
|
|
|
su - www-data -s /bin/bash -c 'php /var/www/html/occ app:list' > /tmp/list_after
|
|
echo "The following apps have beed disabled:"
|
|
diff <(sed -n "/Enabled:/,/Disabled:/p" /tmp/list_before) <(sed -n "/Enabled:/,/Disabled:/p" /tmp/list_after) | grep '<' | cut -d- -f2 | cut -d: -f1
|
|
rm -f /tmp/list_before /tmp/list_after
|
|
fi
|
|
fi
|
|
|
|
exec "$@"
|